Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with BEEPER_PIN -1 or #undef BEEPER_PIN #3999

Closed
ghost opened this issue Jun 10, 2016 · 4 comments
Closed

Compilation error with BEEPER_PIN -1 or #undef BEEPER_PIN #3999

ghost opened this issue Jun 10, 2016 · 4 comments
Labels
Bug: Confirmed ! Needs: Patch A patch is needed to fix this
Milestone

Comments

@ghost
Copy link

ghost commented Jun 10, 2016

After PR #3995(New feature: Non blocking tone queue) was meged, I've gotten compilation errors.
If I set the BEEPER_PIN to -1 for disable beep, it causes compilation error.
error log.txt

If I undefine the BEEPER_PIN by #undef BEEPER_PIN, I got another error.
error log2.txt

Settings:
Configuration.txt
pins_RAMPS_14.txt

@jbrazio
Copy link
Contributor

jbrazio commented Jun 10, 2016

Seems an error with #define HAS_BUZZER, will check ASAP.

@ghost ghost changed the title Compilation error with BEEPER_PIN -1 or #undef BEEPERPIN Compilation error with BEEPER_PIN -1 or #undef BEEPER_PIN Jun 10, 2016
@jbrazio
Copy link
Contributor

jbrazio commented Jun 10, 2016

@esenapaj could you please try the following diff ?

diff --git a/Marlin/ultralcd.h b/Marlin/ultralcd.h
index 5cb1ecc..e855835 100644
--- a/Marlin/ultralcd.h
+++ b/Marlin/ultralcd.h
@@ -27,8 +27,6 @@

 #if ENABLED(ULTRA_LCD)

-  #include "buzzer.h"
-
   #define BUTTON_EXISTS(BN) (defined(BTN_## BN) && BTN_## BN >= 0)
   #define BUTTON_PRESSED(BN) !READ(BTN_## BN)

@jbrazio jbrazio added Bug: Confirmed ! Needs: Patch A patch is needed to fix this labels Jun 10, 2016
@jbrazio jbrazio added this to the 1.1.0 milestone Jun 10, 2016
@ghost
Copy link
Author

ghost commented Jun 10, 2016

could you please try the following diff ?

Thanks for the quick fix.
I've confirmed just now that compilation error is gone by the diff.

jbrazio added a commit to jbrazio/Marlin that referenced this issue Jun 10, 2016
thinkyhead added a commit that referenced this issue Jun 11, 2016
Closes #3999: Compilation error with BEEPER_PIN -1
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 16, 2016
CONSULitAS pushed a commit to CONSULitAS/Marlin-K8200 that referenced this issue Aug 18, 2016
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed ! Needs: Patch A patch is needed to fix this
Projects
None yet
Development

No branches or pull requests

2 participants