-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babystepping - do not idle out #5031
Comments
The default is 15 seconds. You can change it in Configuration_adv.h: #define LCD_TIMEOUT_TO_STATUS 15000 And if you set it long and need to get back to the status screen, the Baby Stepping respects an Encoder Wheel click and will bailout early if you tell it to. You can submit a PR and that will usually start a discussion. One thing I'm toying with doing on the Baby Stepping is remembering how much previous Baby Stepping has moved the nozzle. Right now, every time you enter Baby Stepping, it starts at 0.000 and I'm not sure that is appropriate in an environment where you are using it to re-position the entire Mesh up or down. |
I don't mind the timeouts on other screens though.. just babystepping :) But I can just set it to 30 or 60 and then that's fine. I rarely use my LCD anyways. |
Also... I don't have the 'Press and Hold' of the encoder wheel working yet. But the 'Kill Switch' over ride to get into Z-BabyStepping is working. It doesn't matter if the screen times out because with one easy button push, you are back into it. You might want to give that a try. |
Which branch is that in? |
I am finding "#define LCD_TIMEOUT_TO_STATUS 15000" in ultralcd.h. |
It is in the https://github.com/MarlinFirmware/Marlin/tree/devel-ubl branch. This branch was forked from RCBugFix on July 4th 2016. It works, but it is a 'Development Branch'. With that said, once you learn the process to define a High Resolution Mesh, you can get a new piece of glass fully tuned in in under 30 minutes. (And much of that time, you are not doing any work.) Or... If you are ambitious, the 'Kill Switch' override is only about a dozen lines of code spread across 3 files. You can just move those lines to RCBugFix. |
Here's the solution. Add #if ENABLED(BABYSTEP_XY)
static void _lcd_babystep_x() { _lcd_babystep(X_AXIS, PSTR(MSG_BABYSTEPPING_X)); }
static void _lcd_babystep_y() { _lcd_babystep(Y_AXIS, PSTR(MSG_BABYSTEPPING_Y)); }
static void lcd_babystep_x() { babysteps_done = 0; lcd_goto_screen(_lcd_babystep_x); defer_return_to_status = true; }
static void lcd_babystep_y() { babysteps_done = 0; lcd_goto_screen(_lcd_babystep_y); defer_return_to_status = true; }
#endif
static void _lcd_babystep_z() { _lcd_babystep(Z_AXIS, PSTR(MSG_BABYSTEPPING_Z)); }
static void lcd_babystep_z() { babysteps_done = 0; lcd_goto_screen(_lcd_babystep_z); defer_return_to_status = true; } This patch has been applied in |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I found it annoying getting idled out of babystepping. Staring intently at the bed nozzle... trying to tweak, wait for some more skirt to print... see how it's going... get booted out.
I have a patch I can put a PR in for that disables the idle timeout during babysteps.
(BTW, not sure how to contribute with things like this. Should I just submit the PR and we talk about it then? Or ask here first?)
The text was updated successfully, but these errors were encountered: