Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLA and ABS Preheat Settings maxtemp error #5312

Closed
Kaibob2 opened this issue Nov 27, 2016 · 5 comments
Closed

PLA and ABS Preheat Settings maxtemp error #5312

Kaibob2 opened this issue Nov 27, 2016 · 5 comments
Labels
T: Feature Request Features requested by users.

Comments

@Kaibob2
Copy link
Contributor

Kaibob2 commented Nov 27, 2016

When i edit the PLA and ABS Preheat temperatures via the LCD the Maximum temperature for HEATER_0_MAXTEMP is used for both Materials. In my case Heater 0 is PLA and Heater 1 is ABS.
HEATER_0_MAXTEMP = 250°
HEATER_1_MAXTEMP = 300°

In the preheat settings i can set PLA to maximum 235° (250-15) which is correct, but ABS too.

@Kaibob2
Copy link
Contributor Author

Kaibob2 commented Nov 27, 2016

@Jinxycob This is correct, the default is 275. But what is your point.
I suspect the issue somewhere here in ultralcd.cpp


  void _lcd_control_temperature_preheat_settings_menu(uint8_t material) {
    START_MENU();
    MENU_BACK(MSG_TEMPERATURE);
    MENU_ITEM_EDIT(int3, MSG_FAN_SPEED, &lcd_preheat_fan_speed[material], 0, 255);
    #if TEMP_SENSOR_0 != 0
      MENU_ITEM_EDIT(int3, MSG_NOZZLE, &lcd_preheat_hotend_temp[material], HEATER_0_MINTEMP, HEATER_0_MAXTEMP - 15);
    #endif
    #if TEMP_SENSOR_BED != 0
      MENU_ITEM_EDIT(int3, MSG_BED, &lcd_preheat_bed_temp[material], BED_MINTEMP, BED_MAXTEMP - 15);
    #endif
    #if ENABLED(EEPROM_SETTINGS)
      MENU_ITEM(function, MSG_STORE_EPROM, Config_StoreSettings);
    #endif
    END_MENU();
  }

@Jinxycob
Copy link

sry bud just deleted that comment it was confusing the issue

@thinkyhead
Copy link
Member

thinkyhead commented Nov 28, 2016

The limit is based on the first hotend's limit. I'll make it so that the limit is based on all hotends, but also that you still can't preheat the nozzles above their set maxima.

Done as #5315

@Kaibob2
Copy link
Contributor Author

Kaibob2 commented Nov 29, 2016

#5315 fixed it. Thanks Scott!

@Kaibob2 Kaibob2 closed this as completed Nov 29, 2016
@github-actions
Copy link

github-actions bot commented Apr 1, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

3 participants