Keep drawing menu unless screen changes #5313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2016
Closed
Closed
thinkyhead
force-pushed
the
rc_fix_menu_actions
branch
from
9a06735 to
b9ac109
Compare
thinkyhead
force-pushed
the
rc_fix_menu_actions
branch
from
b9ac109 to
c70a06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #5194
When a menu action is invoked the behavior is to exit from the screen handler. But not all menu actions change screens, so simply exiting will cause menu items not to be rendered.
This PR changes the menu item handler so it only exits if the screen actually changes.