Function "get_sdcard_commands" will cause wdt reset when print sdcard file

[MS1987]

---

Bug Report

• Description: ---
  When I print a gcode file (from sdcard) which has plenty of comment lines continuously, it causes the board reset.

• Analasy: ---
  As the watchdog was enabled, in the function "get_sdcard_commands()" there is code as following:
  if (!sd_count) continue; // skip empty lines (and comment lines)
  This "continue" will cause long time in the get command loop when the gcode file has enougth comment lines to consume.

• Solve: ---
  Replace the "continue" above with "return"

• reproduce:
  Use the gcode file to test.

test.zip

---

[iosonopersia]

Hi @MS1987

Replace the "continue" above with "return"

I suggest to edit code as follows:

  // skip empty lines (and comment lines)
  if (!sd_count) {
      #if ENABLED(USE_WATCHDOG)
          watchdog_reset();
      #endif
      continue;
  }

Do you think this would work?

[MS1987]

@iosonopersia, I agree that your method would prevent the wdt reboot. But it will still block the other operation( like button operation and lcd refresh). So I think skip out will be better. What do you think?

[iosonopersia]

Hi @MS1987,
I thought about it and I think your approach would be better than mine. We should prepare a PR for that.

That behaviour should be used both in get_sdcard_commands() and in get_serial_commands().

I add that in those functions, the cycle continues also if MAX_CMD_SIZE is reached. If that happens, those functions continue to read chars until they find a \n or a \r char. So if someone sends a very long string without \n and \r, the printer will also get stuck for a while, until those EOL characters are found. I'm wondering if we could exit the cycle in that case too.

[thinkyhead]

Patch will be merged shortly.

[thinkyhead]

if someone sends a very long string without \n and \r, the printer will also get stuck for a while

Less worried about this.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.