[2.0.x] L6470 bugfixes & resolve class L6470 name duplication #13011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bob-the-Kuhn
added
PR: Bug Fix
T: HAL & APIs
Let's put it back into the class. See https://en.cppreference.com/w/cpp/language/static |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class L6470 existed both in the library and in L6470_Marlin.h. To resolve this I renamed the one in L6470_Marlin.h to Marlin_L6470.
Fixed a lot of name issues and added in some missing declarations.
The chain[] array shouldn't be in the library's L6470 class because it is not specific to a stepper. I'm doing a PR on the library to make that change. This PR is dependent on the library change.
I did NOT include the XYZ array macro definition fix in this PR. As best I can tell the one that was just merged still causes problems.