Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude most disabled G-codes from build #18919

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Exclude most disabled G-codes from build #18919

merged 5 commits into from
Aug 6, 2020

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Aug 5, 2020 •
edited
Loading

  • Move some flags only used for [features]
  • Use references for style
  • Handle disabled features, within limits
  • Recurse if feature value is a feature name
  • Process all marlin.MY_FEATURE entries in the environment

@thinkyhead thinkyhead force-pushed the bf2_disabled_filter_PR branch 9 times, most recently from 8948040 to 1bf7296 Compare August 6, 2020 03:47
@thinkyhead thinkyhead force-pushed the bf2_disabled_filter_PR branch 13 times, most recently from b43ddbf to 702aa41 Compare August 6, 2020 09:20
@thinkyhead thinkyhead changed the title Tweaks to dependencies script Exclude most disabled G-codes from build Aug 6, 2020
@thinkyhead thinkyhead force-pushed the bf2_disabled_filter_PR branch from 702aa41 to da7be45 Compare August 6, 2020 10:44
@thinkyhead thinkyhead force-pushed the bf2_disabled_filter_PR branch 2 times, most recently from cc754b3 to cdcbafa Compare August 6, 2020 10:56
@thinkyhead thinkyhead force-pushed the bf2_disabled_filter_PR branch from c0b9347 to d759e00 Compare August 6, 2020 13:13
@thinkyhead thinkyhead merged commit 99ba866 into MarlinFirmware:bugfix-2.0.x Aug 6, 2020
@thinkyhead thinkyhead deleted the bf2_disabled_filter_PR branch August 6, 2020 13:14
@rhapsodyv
Copy link
Member

Great!!

Just tested the marlin "default build". Before the script, the build took 25s. With the "old script" version, it took 14s. With your lasts commits, its 9s for me!!!

@bill-orange bill-orange mentioned this pull request Aug 6, 2020
Closed
@rhapsodyv rhapsodyv mentioned this pull request Aug 6, 2020
Merged
Speaka pushed a commit to Speaka/Marlin that referenced this pull request Aug 13, 2020
@thinkyhead @Speaka
Optimize G-code / feature dependencies (MarlinFirmware#18919)
53fee64
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
@thinkyhead @albertogg
Optimize G-code / feature dependencies (MarlinFirmware#18919)
c4fcc8e
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
@thinkyhead @vgadreau
Optimize G-code / feature dependencies (MarlinFirmware#18919)
f2f7f69
ahmetcemturan pushed a commit to ahmetcemturan/Marlin that referenced this pull request Jan 21, 2021
@thinkyhead @ahmetcemturan
Optimize G-code / feature dependencies (MarlinFirmware#18919)
bed20d6
ahmetcemturan added a commit to ahmetcemturan/Marlin that referenced this pull request Jan 23, 2021
@ahmetcemturan
Revert "Optimize G-code / feature dependencies (MarlinFirmware#18919)"
417eeea 
This reverts commit bed20d6.
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
@thinkyhead
Optimize G-code / feature dependencies (MarlinFirmware#18919)
da6e5ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhapsodyv rhapsodyv rhapsodyv left review comments

Assignees
No one assigned
Labels
C: Build / Toolchain PR: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkyhead @rhapsodyv