Tests for Color UI and Robin Nano Boards (and fixes) #19118

rhapsodyv · 2020-08-23T01:37:18Z

Description

Some recent menu changes broke the compilation for New Color UI. I noted that it have no tests.

Benefits

Add test for new color ui.

Related Issues

rhapsodyv · 2020-08-23T01:39:40Z

@ivankravets seems pio dev is broken....

ImportError: cannot import name 'cd' from 'platformio.util' (/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/util.py):

Take a look in the failing tests.

ivankravets · 2020-08-23T03:07:15Z

This is a legacy Core 3.x API. Please use from platformio.fs import cd.

ivankravets · 2020-08-23T03:08:46Z

Should revert back this 3.x API and add warning? We just wanted to clean up a code.

rhapsodyv · 2020-08-23T03:13:39Z

Should revert back this 3.x API and add warning? We just wanted to clean up a code.

Is not our scripts. Is the esp32 framework package

  File "/home/runner/.platformio/platforms/espressif32/builder/frameworks/_embed_files.py", line 21:
74
    from platformio.util import cd

Seems there’re packages that use some legacy code, and they aren’t migrated yet.

ivankravets · 2020-08-23T10:28:22Z

Sorry for these issues. We don't do a major refactoring of our codebase so often. 1 time per a few years. This time it has happened with refactoring our package management infrastructure. Maybe, it makes sense to release it as PIO Core 5.0. However, we don't see a reason in PIO Core 5.0 if all user projects are compatible with PIO Core 4.4 changes.

@rhapsodyv thanks for your report. It is an outdated version of ESP32 dev platform. I've just back ported util.cd API.

@thinkyhead "PIO-dev unsuitable for CI", why it is unsuitable? Is it better if we fix all known issues before the final releases of both projects? How about if we switch back to "develop" branch after PIO Core 4.4 release? We plan to have it on Tuesday. We don't have any significant changes in PIO Core in our roadmap for the next months.

Thanks!

rhapsodyv · 2020-08-23T12:57:45Z

@thinkyhead we need release 2.0.6.1 with #19034 before Tuesday. If we don't, any build using the upcoming pio will be broken. 🙁

ivankravets · 2020-08-23T13:07:26Z

Do you have any blockers for 2.0.6.1? Indeed, we can wait in this case.

rhapsodyv · 2020-08-23T18:02:15Z

@ivankravets I think we have more issues:

2020-08-23.3240891Z �[0;32m[Test esp32] �[0mESP32 with WIFISUPPORT and WEBSUPPORT...
AttributeError: module 'platformio.exception' has no attribute 'InternetIsOffline':
  File "/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/builder/main.py", line 169:
    env.SConscript("$BUILD_SCRIPT")
  File "/home/runner/.platformio/packages/tool-scons/scons-local-4.0.1/SCons/Script/SConscript.py", line 598:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/home/runner/.platformio/packages/tool-scons/scons-local-4.0.1/SCons/Script/SConscript.py", line 287:
    exec(compile(scriptdata, scriptname, 'exec'), call_stack[-1].globals)
  File "/home/runner/.platformio/platforms/espressif32/builder/main.py", line 210:
    target_elf = env.BuildProgram()
  File "/home/runner/.platformio/packages/tool-scons/scons-local-4.0.1/SCons/Environment.py", line 219:
    return self.method(*nargs, **kwargs)
  File "/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/builder/tools/platformio.py", line 62:
    env.ProcessProjectDeps()
  File "/home/runner/.platformio/packages/tool-scons/scons-local-4.0.1/SCons/Environment.py", line 219:
    return self.method(*nargs, **kwargs)
  File "/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/builder/tools/platformio.py", line 140:
    project_lib_builder = env.ConfigureProjectLibBuilder()
  File "/home/runner/.platformio/packages/tool-scons/scons-local-4.0.1/SCons/Environment.py", line 219:
    return self.method(*nargs, **kwargs)
  File "/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/builder/tools/piolib.py", line 1047:
    project.install_dependencies()
  File "/opt/hostedtoolcache/Python/3.7.8/x64/lib/python3.7/site-packages/platformio/builder/tools/piolib.py", line 885:
    except (UnknownPackageError, exception.InternetIsOffline) as e:

rhapsodyv · 2020-08-23T18:03:16Z

AttributeError: module 'platformio.exception' has no attribute 'InternetIsOffline':

ivankravets · 2020-08-23T18:08:40Z

@rhapsodyv thanks for the report! Fixed in platformio/platformio-core@24f85a3

P.S: It was a typo with excluding "no-member" from PyLint.

asasin6666 · 2020-08-23T19:14:55Z

F23:09, 23 августа 2020 г., Ivan Kravets <[email protected]>: @rhapsodyv thanks for the report! Fixed in platformio/platformio-core@24f85a3 P.S: It was a typo with excluding "no-member" from PyLint. —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe. egor

asasin6666 · 2020-08-23T19:15:19Z

23:09, 23 августа 2020 г., Ivan Kravets <[email protected]>: @rhapsodyv thanks for the report! Fixed in platformio/platformio-core@24f85a3 P.S: It was a typo with excluding "no-member" from PyLint. —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe. egor

thinkyhead · 2020-08-24T03:04:30Z

why it is unsuitable?

I find it frustrating to have to stop at random times to deal with a morphing PlatformIO when there are so many notifications and pull requests piling up. To avoid these interruptions I would prefer to stick with a known working version of PlatformIO until the kinks are worked out.

If the build of Marlin is helpful for catching errors in PlatformIO, perhaps we can set up a copy of Marlin under a different GitHub account, have it re-build itself each time there's a new push to PlatformIO, and then have it ping you if there's a build failure of any kind.

Do you have any blockers for 2.0.6.1? Indeed, we can wait in this case.

Before tagging 2.0.6.1 I had hoped to find and fix:

A reported freeze caused by long filenames and some LCD screens; probably a buffer overflow.
A confirmed freeze that occurs with gradient mixing.

But so far I haven't been able to narrow down the cause of either of these issues.

ivankravets · 2020-08-24T11:22:45Z

@thinkyhead thanks for the honest feedback! I think I asked to switch to PIO dev-version at the wrong moment. However, you are right. You have tons of own issues and it does not make sense to spent time on our issues.

So, should we postpone 4.4 release? We want to do this tomorrow becase there huge update of PlatformIO IDE 2.0 for VSCode. It depends on PlatformIO Core 4.4. It might be useful for Marlin project as well. It bring support for custom targets and IDE automatically provides UI for them.

thinkyhead · 2020-08-24T18:22:21Z

So, should we postpone 4.4 release? We want to do this tomorrow becase there huge update…

I don't want anything to hold up your schedule, and Marlin needs to be adaptable. If you feel confident you've got all the breaking issued solved, I defer to your judgment. I've been using the 4.4 alpha / beta for a while and the most important thing is that it builds the project just fine and we don't need to make any changes to platformio.ini for compatibility. Plus, it will be stabilized, in contrast to the mercurial develop branch.

It bring support for custom targets and … UI for them.

That's good news! I look forward to seeing it in action.

I believe that, now, if an environment uses extends it still needs to include platform or it won't be respected. Has that been changed?

ivankravets · 2020-08-25T10:55:56Z

I believe that, now, if an environment uses extends it still needs to include platform or it won't be respected. Has that been changed?

This also has been fixed. We rewrote INI parser in Node.JS.

rhapsodyv · 2020-08-25T22:43:23Z

@thinkyhead @ivankravets CI using PIO dev is broken again. 🥳 😅

Error: Development platform 'nxplpc-arduino-lpc176x' is not compatible with PlatformIO Core v5.0.0-b.1 and depends on PlatformIO Core ^4.0.0.

Maybe @p3p need to do some adjustment?

p3p · 2020-08-25T23:06:44Z

No idea, I will need to look up all the major changes that required the platformio major version bump and make sure every thing is compatible before doing a release with the platformio version requirement updated.

If the only breaking changes are the manifest file deprecation then it will be an easy update, I will just have to get used to publishing packages ^^.

rhapsodyv · 2020-08-25T23:46:19Z

@ivankravets Is there any way to lock users in a specific pio version?

ivankravets · 2020-08-26T03:44:56Z

We have decided to release everything under 5.0. A lot of changes... So, it should close any questions about why we modified our internal package structure, and etc.

In any case, all projects and dev-platforms are compatible between 1.0 and 5.0.

5.0.0-beta.2 is out. I hope this is the last issue. We know automatically mark all PIO Core 1.0-4.0 dev-platforms compatible with 5.0. See platformio/platformio-core@0db39cc

P.S: Thanks for pinging to me!

tests for color ui and robin nano boards

7f531b0

PIO-dev unsuitable for CI

76a58a4

thinkyhead added the C: LCD & Controllers label Aug 24, 2020

Update test-builds.yml

5b9b596

thinkyhead merged commit f7fe499 into MarlinFirmware:bugfix-2.0.x Aug 24, 2020

albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020

Color UI + Robin Nano test (MarlinFirmware#19118)

2e064f4

thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Sep 2, 2020

Color UI + Robin Nano test (MarlinFirmware#19118)

e3fed72

rhapsodyv deleted the color-ui-test-robin-nano branch October 25, 2020 00:32

vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020

Color UI + Robin Nano test (MarlinFirmware#19118)

17d9a32

kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021

Color UI + Robin Nano test (MarlinFirmware#19118)

40b8945

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tests for Color UI and Robin Nano Boards (and fixes) #19118

Tests for Color UI and Robin Nano Boards (and fixes) #19118

rhapsodyv commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020 •

edited

Loading

ivankravets commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020 •

edited

Loading

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

asasin6666 commented Aug 23, 2020 via email

asasin6666 commented Aug 23, 2020 via email

thinkyhead commented Aug 24, 2020

ivankravets commented Aug 24, 2020

thinkyhead commented Aug 24, 2020

ivankravets commented Aug 25, 2020

rhapsodyv commented Aug 25, 2020

p3p commented Aug 25, 2020 •

edited

Loading

rhapsodyv commented Aug 25, 2020

ivankravets commented Aug 26, 2020

Tests for Color UI and Robin Nano Boards (and fixes) #19118

Tests for Color UI and Robin Nano Boards (and fixes) #19118

Conversation

rhapsodyv commented Aug 23, 2020

Description

Benefits

Related Issues

rhapsodyv commented Aug 23, 2020 • edited Loading

ivankravets commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

rhapsodyv commented Aug 23, 2020 • edited Loading

rhapsodyv commented Aug 23, 2020

ivankravets commented Aug 23, 2020

asasin6666 commented Aug 23, 2020 via email

asasin6666 commented Aug 23, 2020 via email

thinkyhead commented Aug 24, 2020

ivankravets commented Aug 24, 2020

thinkyhead commented Aug 24, 2020

ivankravets commented Aug 25, 2020

rhapsodyv commented Aug 25, 2020

p3p commented Aug 25, 2020 • edited Loading

rhapsodyv commented Aug 25, 2020

ivankravets commented Aug 26, 2020

rhapsodyv commented Aug 23, 2020 •

edited

Loading

rhapsodyv commented Aug 23, 2020 •

edited

Loading

p3p commented Aug 25, 2020 •

edited

Loading