12-bit ADC resolution for BIGTREE_SKR_PRO #20558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heet at https://www.st.com/resource/en/datasheet/dm00037051.pdf) — ADC_RESOLUTION defaults to 10 in stm32 arduino: https://github.com/stm32duino/Arduino_Core_STM32/blob/a4058ae1c9e6234b7411ae8214bbd12c99961cca/cores/arduino/pins_arduino.h#L343
|
Should this also be enabled on the GTR and other boards with similar MCUs? |
Every STM32 mcu can use 12 bit. The STM32F1 hal uses 32 bit for all boards. We should make STM32 use 12 bit too. I opened this issue to not forget: #20539 I think we should just add it in the stm32 base env, instead of adding in each board. |
Agreed. |
|
I'm closing this in favor of a more generic one, that will set 12 to all STM32 boards: #20562 |
MoellerDi
deleted the
Marlin-PR/bugfix-2.0.x_12-bit_ADC_BIGTREE_SKR_PRO
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADC_RESOLUTION defaults to 10 in stm32 arduino: https://github.com/stm32duino/Arduino_Core_STM32/blob/a4058ae1c9e6234b7411ae8214bbd12c99961cca/cores/arduino/pins_arduino.h#L343
BIGTREE_SKR_PRO can use 12-bit ADC (as per stm32f407zgt6 datasheet at https://www.st.com/resource/en/datasheet/dm00037051.pdf)
Benefits
Better PID stability
Configurations
None
Related Issues
#20519, #20539