fix enable pins for SANGUINOLOLU boards < version 1.2 #20682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharts
pushed a commit
to tharts/Marlin
that referenced
this pull request
Jan 6, 2021
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Jan 8, 2021
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (105 commits) [cron] Bump distribution date (2021-01-08) Fix M48 output (MarlinFirmware#20713) Improved MKS Robin support (MarlinFirmware#19333) Preheat before Power Loss Recovery homing (MarlinFirmware#20697) [cron] Bump distribution date (2021-01-07) Custom build_flags by feature (MarlinFirmware#20692) [cron] Bump distribution date (2021-01-06) Multi-Z stepper inverting (MarlinFirmware#20678) Fix Azteeg X3 macro typo (MarlinFirmware#20681) Define SANGUINOLOLU 1.1 enable pins (MarlinFirmware#20682) No BTN_ENC_EN on Anet 10 (MarlinFirmware#20684) Temperature report followup (MarlinFirmware#20687) Adjustable precision in M105 temperature report (MarlinFirmware#20602) Don't apply hotend_offset.z to Z soft endstops (MarlinFirmware#20675) Indent tool_change_prime Clarify solenoid active / magnet-on state Defer "quiet probing" till the last Z bump (MarlinFirmware#20610) Solenoid cleanups [cron] Bump distribution date (2021-01-05) Remove untranslated strings ...
dpreed
pushed a commit
to dpreed/Marlin_2.0.x
that referenced
this pull request
Feb 5, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
#define MOTHERBOARD BOARD_SANGUINOLOLU_11
Description
This result in a compile error
#error "E0_STEP_PIN, E0_DIR_PIN, or E0_ENABLE_PIN not defined for this board."
This error is correct as all enable pin are incorrectly set to -1 on SANGUINOLOLU boards < version 1.2
I have set all enable pins back to 4 and checked for conflicts with other 1284p based boards.
Benefits
MOTHERBOARD BOARD_SANGUINOLOLU_11 compiles as expected.
Related Issues
None