Supporting REPRAP_DISCOUNT_SMART_CONTROLLER #23522
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for the REPRAP_DISCOUNT_SMART_CONTROLLER LCD module with the Ramps 1.4 Plus board This closes the issue MarlinFirmware#23501
|
Thanks for your contribution! Unfortunately we can't accept PRs directed at release branches. We make patches to the bugfix branches and only later do we push them out as releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the REPRAP_DISCOUNT_SMART_CONTROLLER LCD module with the Ramps 1.4 Plus board
Description
The current code only supports the REPRAPWORLD_GRAPHICAL_LCD (LCD12864) and doesn't support the REPRAP_DISCOUNT_SMART_CONTROLLER (LCD2004).
This PR, which I have tested and currently running on my printer, fixes the issue by assigning the right pins to the board. I have also updated the comment field with the Pin-out of the boards connectors EXP1 and EXP2.
Benefits
Fixes the pins for the LCD board
REPRAP_DISCOUNT_SMART_CONTROLLERwhen used with the RAMPS 1.4 PlusRelated Issues
#23501
Images
This image shows the board pin-out
The LCD pin mapping