Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bed leveling issues #26819

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Fix bed leveling issues #26819

merged 3 commits into from
Apr 7, 2024

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Feb 26, 2024 •
edited
Loading

Description

Two bugs

  1. a while loop in line_to_destination_cartesian can loop forever.
    Code has while (cnt) but variable cnt is a structure with a X and a Y component. This while does not end.
    Replaced with `while (cnt.x || cnt.y) now addressed by 🐛 Fix bool evalution of XYval and similar types #26936

  2. After ba08dcf
    MESH_BED_LEVELING with SEGMENT_LEVELED_MOVES disabled fails to build.
    Updated variable types to be unsigned.

Requirements

Bed leveling (UBL or MESH) with SEGMENT_LEVELED_MOVES disabled

Benefits

Works as expected

Related Issues

  • [BUG] G26 with SEGMENT_LEVELED_MOVES disabled with UBL has out of bound moves. #26816
  • [BUG] IS_CARTHESIAN && DISABLED(SEGMENT_LEVELED_MOVES) wont compile error: conversion from 'XYval<unsigned char>' to non-scalar type 'XYval<signed char>' requested #26718
    •

    @thisiskeithb thisiskeithb linked an issue Feb 26, 2024 that may be closed by this pull request
    [BUG] IS_CARTHESIAN && DISABLED(SEGMENT_LEVELED_MOVES) wont compile error: conversion from 'XYval<unsigned char>' to non-scalar type 'XYval<signed char>' requested #26718
    Closed
    1 task
    @classicrocker883
    Copy link
    Contributor

    i have a question, for cartesian beds, is it better to have SEGMENT_LEVELED_MOVES? and what would the advantages/disadvantages be for being defined or undefined?

    @ellensp
    Copy link
    Contributor Author

    ellensp commented Apr 5, 2024 •
    edited
    Loading

    closing as sjasonsmith found a better fix. #26936
    That fixes the bool operation in XYval, vs just avoiding the broken bool

    @ellensp ellensp closed this Apr 5, 2024
    @thisiskeithb
    Copy link
    Member

    thisiskeithb commented Apr 5, 2024 •
    edited
    Loading

    closing as sjasonsmith found a better fix. #26936
    That fixes the bool operation in XYval, vs just avoiding the broken bool

    What about the MBL bug?

    @ellensp
    Copy link
    Contributor Author

    ellensp commented Apr 5, 2024 •
    edited
    Loading

    oh darn, its a two parter... part 1 is addressed by #26936
    But part 2... updated PR to just address this

    @ellensp ellensp reopened this Apr 5, 2024
    @sjasonsmith sjasonsmith merged commit a337a43 into MarlinFirmware:bugfix-2.1.x Apr 7, 2024
    61 checks passed
    @ellensp ellensp deleted the bed-leveling-issues branch April 7, 2024 04:49
    RPGFabi pushed a commit to RPGFabi/Marlin that referenced this pull request Jun 15, 2024
    @ellensp @RPGFabi
    🩹 Fix type mismatch when SEGMENT_LEVELED_MOVES disabled (MarlinFirmwa…
    5412c17 
    …re#26819)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    F: Calibration PR: Bug Fix
    Projects
    None yet
    Milestone
    No milestone
    4 participants
    @ellensp @classicrocker883 @thisiskeithb @sjasonsmith