Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements park nozzle feature #4299

Merged
merged 2 commits into from
Jul 17, 2016

Conversation

jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Jul 14, 2016

//
// Nozzle Park -- EXPERIMENTAL
//
// When enabled allows the user to define a special XYZ position, inside the
// machine's topology, to park the nozzle when idle or when receiving the G27
// command.
//
// The "P" paramenter controls what is the action applied to the Z axis:
//    P0: (Default) If current Z-pos is lower than Z-park then the nozzle will
//        be raised to reach Z-park height.
//
//    P1: No matter the current Z-pos, the nozzle will be raised/lowered to
//        reach Z-park height.
//
//    P2: The nozzle height will be raised by Z-park amount but never going over
//        the machine's limit of Z_MAX_POS.
//

This was feature was requested at #4221.

@jbrazio jbrazio force-pushed the feature/g27-park-nozzle branch 2 times, most recently from 1b1d566 to dcffa6f Compare July 14, 2016 23:18
* Nozzle park
*/
#if ENABLED(NOZZLE_PARK_FEATURE) && !HAS_BED_PROBE
#error Due to internal dependencies you must have a bed probe for NOZZLE_PARK_FEATURE to work
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs quotes. And just stating the requirement is fine. (Internal dependencies is implied.)

#error "NOZZLE_PARK_FEATURE currently requires a bed probe."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be rebased Scott, now we have do_blocking_move_to_*() freeeeeeee ! ;-D

@jbrazio jbrazio force-pushed the feature/g27-park-nozzle branch from dcffa6f to 1b41595 Compare July 16, 2016 02:58
@jbrazio
Copy link
Contributor Author

jbrazio commented Jul 16, 2016

Note: Travis will bark until #4320 is merged and this is rebased.

@jbrazio jbrazio force-pushed the feature/g27-park-nozzle branch 2 times, most recently from 7884b53 to aa9afd6 Compare July 16, 2016 10:49
@jbrazio jbrazio force-pushed the feature/g27-park-nozzle branch from aa9afd6 to 336481e Compare July 16, 2016 11:08
@thinkyhead thinkyhead merged commit bf16ae5 into MarlinFirmware:RCBugFix Jul 17, 2016
@jbrazio jbrazio deleted the feature/g27-park-nozzle branch July 17, 2016 17:31
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
@thinkyhead thinkyhead mentioned this pull request Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants