-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use blocking_move, current_position in G28 homing #4338
Conversation
931fad4
to
e5556d9
Compare
e5556d9
to
1e57a6a
Compare
@@ -1603,6 +1603,7 @@ inline void set_homing_bump_feedrate(AxisEnum axis) { | |||
SERIAL_ECHOLNPGM("Warning: Homing Bump Divisor < 1"); | |||
} | |||
feedrate_mm_m = homing_feedrate_mm_m[axis] / hbd; | |||
return feedrate_mm_m; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When my run_z_probe()
changes (AnHardt#57) are in set_homing_bump_feedrate()
can go to get_homing_bump_feedrate(AxisEnum axis)
and
feedrate_mm_m = homing_feedrate_mm_m[axis] / hbd;
can go.
I'm still not sure how to name the probing speeds. (AnHardt#57 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about I merge this and you rebase AnHardt#57 on the newest?
c8f80bc
to
86eb525
Compare
It seems that this PR broke G28 of DELTA. If I revert the commit 1e57a6a (Use blocking_move, current_position in G28 homing), carriages gets right behavior.
|
No. 1e57a6a is the summary of AnHardt#57. But AnHardt#57 was a preview. Hopefully #4342 is the fix. |
The side-effects and original intent of all the functions being used has to be considered. Don't just assume you can drop-in replace something because it happens to more-or-less do the same thing. I don't mind reverting all the homing and leveling code to 2 weeks ago if it means we get back to the baseline where things were working, and then we do a much more thoughtful cleaning up. |
Based on AnHardt#58
Addressing #4325 and perhaps other homing / leveling issues.