Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed timestamp_t to duration_t #4390

Merged
merged 2 commits into from
Jul 24, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Marlin/Marlin_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
#include "pins_arduino.h"
#include "math.h"
#include "nozzle.h"
#include "timestamp_t.h"
#include "duration_t.h"

#if ENABLED(USE_WATCHDOG)
#include "watchdog.h"
Expand Down Expand Up @@ -4058,13 +4058,13 @@ inline void gcode_M17() {
*/
inline void gcode_M31() {
char buffer[21];
timestamp_t time(print_job_timer.duration());
time.toString(buffer);
duration_t elapsed = print_job_timer.duration();
elapsed.toString(buffer);

lcd_setstatus(buffer);

SERIAL_ECHO_START;
SERIAL_ECHOPGM(MSG_PRINT_TIME " ");
SERIAL_ECHOPGM("Print time: ");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So MSG_PRINT_TIME isn't used anymore, right? Should be removed from language files ASAP (#4395)

SERIAL_ECHOLN(buffer);

thermalManager.autotempShutdown();
Expand Down
155 changes: 155 additions & 0 deletions Marlin/duration_t.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,155 @@
/**
* Marlin 3D Printer Firmware
* Copyright (C) 2016 MarlinFirmware [https://github.com/MarlinFirmware/Marlin]
*
* Based on Sprinter and grbl.
* Copyright (C) 2011 Camiel Gubbels / Erik van der Zalm
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

#ifndef __DURATION_T__
#define __DURATION_T__

struct duration_t {
/**
* @brief Duration is stored in seconds
*/
uint32_t value;

/**
* @brief Constructor
*/
duration_t()
: duration_t(0) {};

/**
* @brief Constructor
*
* @param seconds The number of seconds
*/
duration_t(uint32_t const &seconds) {
this->value = seconds;
}

/**
* @brief Equality comparison
* @details Overloads the equality comparison operator
*
* @param value The number of seconds to compare to
* @return True if both durations are equal
*/
bool operator==(const uint32_t &value) const {
return (this->value == value);
}

/**
* @brief Inequality comparison
* @details Overloads the inequality comparison operator
*
* @param value The number of seconds to compare to
* @return False if both durations are equal
*/
bool operator!=(const uint32_t &value) const {
return ! this->operator==(value);
}

/**
* @brief Formats the duration as years
* @return The number of years
*/
inline uint8_t year() const {
return this->day() / 365;
}

/**
* @brief Formats the duration as days
* @return The number of days
*/
inline uint16_t day() const {
return this->hour() / 24;
}

/**
* @brief Formats the duration as hours
* @return The number of hours
*/
inline uint32_t hour() const {
return this->minute() / 60;
}

/**
* @brief Formats the duration as minutes
* @return The number of minutes
*/
inline uint32_t minute() const {
return this->second() / 60;
}

/**
* @brief Formats the duration as seconds
* @return The number of seconds
*/
inline uint32_t second() const {
return this->value;
}

/**
* @brief Formats the duration as a string
* @details String will be formated using a "full" representation of duration
*
* @param buffer The array pointed to must be able to accommodate 21 bytes
*
* Output examples:
* 123456789012345678901 (strlen)
* 135y 364d 23h 59m 59s
* 364d 23h 59m 59s
* 23h 59m 59s
* 59m 59s
* 59s
*/
void toString(char *buffer) const {
int y = this->year(),
d = this->day() % 365,
h = this->hour() % 24,
m = this->minute() % 60,
s = this->second() % 60;

if (y) sprintf_P(buffer, PSTR("%iy %id %ih %im %is"), y, d, h, m, s);
else if (d) sprintf_P(buffer, PSTR("%id %ih %im %is"), d, h, m, s);
else if (h) sprintf_P(buffer, PSTR("%ih %im %is"), h, m, s);
else if (m) sprintf_P(buffer, PSTR("%im %is"), m, s);
else sprintf_P(buffer, PSTR("%is"), s);
}

/**
* @brief Formats the duration as a string
* @details String will be formated using a "digital" representation of duration
*
* @param buffer The array pointed to must be able to accommodate 10 bytes
*
* Output examples:
* 1234567890 (strlen)
* 1193046:59
*/
void toDigital(char *buffer) const {
int h = this->hour() % 24,
m = this->minute() % 60;

sprintf_P(buffer, PSTR("%02i:%02i"), h, m);
}
};

#endif // __DURATION_T__
12 changes: 6 additions & 6 deletions Marlin/printcounter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#include "Marlin.h"
#include "printcounter.h"
#include "timestamp_t.h"
#include "duration_t.h"

PrintCounter::PrintCounter(): super() {
this->loadStats();
Expand Down Expand Up @@ -94,7 +94,7 @@ void PrintCounter::saveStats() {

void PrintCounter::showStats() {
char buffer[21];
timestamp_t time;
duration_t elapsed;

SERIAL_PROTOCOLPGM(MSG_STATS);

Expand All @@ -111,8 +111,8 @@ void PrintCounter::showStats() {
SERIAL_EOL;
SERIAL_PROTOCOLPGM(MSG_STATS);

time.timestamp = this->data.printTime;
time.toString(buffer);
elapsed = this->data.printTime;
elapsed.toString(buffer);

SERIAL_ECHOPGM("Total time: ");
SERIAL_ECHO(buffer);
Expand All @@ -123,8 +123,8 @@ void PrintCounter::showStats() {
SERIAL_ECHOPGM(")");
#endif

time.timestamp = this->data.longestPrint;
time.toString(buffer);
elapsed = this->data.longestPrint;
elapsed.toString(buffer);

SERIAL_ECHOPGM(", Longest job: ");
SERIAL_ECHO(buffer);
Expand Down
128 changes: 0 additions & 128 deletions Marlin/timestamp_t.h

This file was deleted.

12 changes: 7 additions & 5 deletions Marlin/ultralcd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

#if ENABLED(PRINTCOUNTER)
#include "printcounter.h"
#include "timestamp_t.h"
#include "duration_t.h"
#endif

int preheatHotendTemp1, preheatBedTemp1, preheatFanSpeed1,
Expand Down Expand Up @@ -1979,13 +1979,15 @@ void kill_screen(const char* lcd_msg) {
STATIC_ITEM(MSG_INFO_PRINT_COUNT ": ", false, false, itostr3left(stats.totalPrints)); // Print Count: 999
STATIC_ITEM(MSG_INFO_COMPLETED_PRINTS" : ", false, false, itostr3left(stats.finishedPrints)); // Completed : 666

timestamp_t time(stats.printTime);
time.toString(buffer);
duration_t elapsed = stats.printTime;
elapsed.toString(buffer);

STATIC_ITEM(MSG_INFO_PRINT_TIME ": ", false, false); // Total print Time:
STATIC_ITEM("", false, false, buffer); // 99y 364d 23h 59m 59s

time.timestamp = stats.longestPrint;
time.toString(buffer);
elapsed = stats.longestPrint;
elapsed.toString(buffer);

STATIC_ITEM(MSG_INFO_PRINT_LONGEST ": ", false, false); // Longest job time:
STATIC_ITEM("", false, false, buffer); // 99y 364d 23h 59m 59s

Expand Down
Loading