Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simplified Z correction in G29 when possible #4781

Merged

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Sep 10, 2016

For linear/planar bed leveling only.

  • If XY hasn't changed since the last point was probed, then it's possible to use the last probe point to determine the "true" Z position. If the bed is flat (not warped) and the probe is accurate then this will produce the most accurate Z position possible.

An additional refinement would be to preserve the probed point array and compare the leveled Z at all probed points to the actual measured Z at all points, adding up and taking the average of the differences.

  • Add conditionals for kinematics and leveling types
  • Rename variables to better reflect their role in nonlinear leveling

@thinkyhead thinkyhead force-pushed the rc_final_z_correction branch 24 times, most recently from 7fb145f to 12912b7 Compare September 13, 2016 10:28
@lolivet
Copy link

lolivet commented Sep 13, 2016

can i use this on my Robo 3D R1?

@thinkyhead
Copy link
Member Author

@lolivet Sure, it's just Marlin, but attempts to correct the Z position at the end of G29.

@thinkyhead thinkyhead force-pushed the rc_final_z_correction branch 2 times, most recently from eb91751 to b5e0399 Compare September 13, 2016 22:34
@thinkyhead thinkyhead force-pushed the rc_final_z_correction branch from b5e0399 to d0ce563 Compare September 13, 2016 22:53
@thinkyhead thinkyhead force-pushed the rc_final_z_correction branch from d0ce563 to 57564ae Compare September 14, 2016 07:03
@thinkyhead thinkyhead merged commit d41eeb6 into MarlinFirmware:RCBugFix Sep 16, 2016
@thinkyhead thinkyhead deleted the rc_final_z_correction branch September 16, 2016 20:14
@lolivet
Copy link

lolivet commented Sep 16, 2016

tanks bro. works perfectly

@thinkyhead thinkyhead mentioned this pull request Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants