-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve M48 output; Add min, max, range, etc. #4958
Conversation
One thing that probably needs to be changed is: double mean = 0.0, sigma = 0.0, sample_set[n_samples], min = 99999.0, max = -99999.0; (the max= part... The other changes on that line are not necessary! :) ) |
Probably not much practical difference (or do some 3d printers have negative z probe trigger points?), but no problem. That's definitely cleaner/more proper. |
Yes... The Inductive probes typically are positioned above the nozzle. The micro-switch probes typically have a negative offset. But especially when the machine is using the nozzle as a probe we want to be able to catch negative numbers. Thanks for the Push Request! I'll merge it in the morning and I'm going to replicate the code over in the devel_ubl branch also. |
Ah, then that was an important change! I wasn't aware of that. No problem! Also, speaking of the devel-ubl branch, I noticed there's no BLTOUCH support (using #defines - obviously can still configure the servo manually). Do you want me to add it, or is that something that will just get picked up when devel-ubl becomes the main development branch? Not sure how that's going to be handled, but thought I'd see if that would be helpful. |
The devel_ubl branch forked on July 4th 2016. The BLTOUCH stuff was added to RCBugFix after that point in time. The current plan is when RCBugFix goes final (or who knows? maybe when RC8 starts?) we will bring devel_ubl up to date with all the changes that have happened. If you have a BLTOUCH and want to use the devel_ubl branch, it would be good to bring it up to date. There are probably other BLTOUCH users that could start using the devel_ubl branch and helping to test and improve it. |
Okay, I'll take a look at doing that this week. |
Improvements to M48 output, per #4953.