Only issue MAXTEMP when heating #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fulg
commented
Oct 24, 2016
| @@ -1809,7 +1809,7 @@ void Temperature::isr() { | |||
|
|
|||
| for (uint8_t e = 0; e < COUNT(temp_dir); e++) { | |||
| const int tdir = temp_dir[e], rawtemp = current_temperature_raw[e] * tdir; | |||
| if (rawtemp > maxttemp_raw[e] * tdir) max_temp_error(e); | |||
| if (rawtemp > maxttemp_raw[e] * tdir && target_temperature[e] > 0.0f) max_temp_error(e); | |||
There was a problem hiding this comment.
Should I check for !is_preheating(e) like MINTEMP below? It didn't seem safe to add.
Fulg
force-pushed
the
RCBugFix
branch
2 times, most recently
from
9621a8d to
2aa12d7
Compare
Closed
This was referenced Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #5075, my printer was randomly throwing MAXTEMP errors while idle and I could not figure out why. Throwing MAXTEMP only when heating allows me to use
SHOW_TEMP_ADC_VALUESand debug the issue without the firmware going in a panic.