Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the priority between path_info and param #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MaxPerl
Copy link

@MaxPerl MaxPerl commented Nov 29, 2016

Hello Martin,

with the following patch I would like to give the user the opportunity to specify with mode_param{'priority'=>'param'} whether path_info or param should be the priority. At the moment if mode_param{'path_info' => 1} or similar is set, then always path_info is taken if it is not empty (this means is "/").

This patch gives the user more flexibility. You can specify a run mode with a hidden field or with a button and can display any path you want. Especially specifying a runmode with a button is at the moment not possible, when mode_param{'path_info'} is set to a true vale

There are no backward compatibility problems expectable because without the additional option, CGI::App behaves as always.

POD doc will follow the next weeks (perhaps earlier)
Best wishes,
Max

Give the user the opportunity to specify whether path_info or param should be the priority
@MaxPerl
Copy link
Author

MaxPerl commented Dec 2, 2016

Hi Martin,
I added POD and the method mode_param_priority. I need this method to enable the priority setting also in CGI::Application::Dispatch::PSGI (do you know who is the maintainer of that?)
Best wishes,
Max
PS.: Shall I put Docu for the mode_param_priority method, too? I think under normal circumstances this method is not so important, but I can write one or two sentences...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant