Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Bad Smells in spoon.pattern.PatternBuilderHelper #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

laughing-train[bot]
Copy link

Repairing Code Style Issues

UnnecessaryToStringCall

The toString() method is not needed in cases the underlying method handles the conversion. Also calling toString() on a String is redundant. Removing them simplifies the code.

Changes:

  • Remove redudant toString() call in body.toString()
  • Remove redudant toString() call in body.toString()

@coveralls
Copy link

Pull Request Test Coverage Report for Build #414

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 40 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 87.123%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/spoon/pattern/PatternBuilderHelper.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/spoon/pattern/internal/PatternPrinter.java 1 94.26%
src/main/java/spoon/reflect/meta/impl/ModelRoleHandlers.java 12 92.61%
src/main/java/spoon/support/visitor/replace/ReplacementVisitor.java 27 96.79%
Totals Coverage Status
Change from base Build #408: -0.1%
Covered Lines: 28308
Relevant Lines: 32492

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants