Spin IncludeComplete's destructor until scanning completes (#147)

MaskRay · Oct 24, 2019 · 0b53720 · 0b53720
1 parent fb02b0e
commit 0b53720
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/include_complete.cc b/src/include_complete.cc
@@ -90,6 +90,12 @@ CompletionItem BuildCompletionItem(const std::string &path,
 IncludeComplete::IncludeComplete(Project *project)
     : is_scanning(false), project_(project) {}
 
+IncludeComplete::~IncludeComplete() {
+  // Spin until the scanning has completed.
+  while (is_scanning.load())
+    std::this_thread::sleep_for(std::chrono::milliseconds(100));
+}
+
 void IncludeComplete::Rescan() {
   if (is_scanning || LLVM_VERSION_MAJOR >= 8)
     return;

diff --git a/src/include_complete.hh b/src/include_complete.hh
@@ -14,6 +14,7 @@ struct Project;
 
 struct IncludeComplete {
   IncludeComplete(Project *project);
+  ~IncludeComplete();
 
   // Starts scanning directories. Clears existing cache.
   void Rescan();