Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam tilt correction #778

Closed
wants to merge 2 commits into from

Conversation

johnboiles
Copy link
Contributor

I'm starting to cherry-pick features and fixes from @madgrizzle's fork so that we can get them merged back upstream.

This change is the GroundControl change for beam tilt correction (added to the firmware in MaslowCNC/Firmware#467)

@MaslowCommunityGardenRobot
Copy link
Collaborator

Congratulations on the pull request @johnboiles

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

@blurfl
Copy link
Collaborator

blurfl commented Oct 16, 2018

As I commented on the related
P
R in Firmware, this one might best wait until it is needed in the Kinematics calculations. At that point, it will need documentation on what units to use and how to measure it.

@blurfl
Copy link
Collaborator

blurfl commented Oct 16, 2018

@BarbourSmith is off line for a couple days, how about closing this for a few days until he gets back?

@johnboiles
Copy link
Contributor Author

Closing this until @BarbourSmith is back. Let's continue the discussion though.

@johnboiles johnboiles closed this Oct 16, 2018
@johnboiles johnboiles changed the base branch from master to build-OSX October 17, 2018 03:11
@johnboiles johnboiles changed the base branch from build-OSX to master October 17, 2018 03:11
@johnboiles
Copy link
Contributor Author

I made whitespace changes and pulled in the top beam tilt into the simulator in the madgrizzle:beam-tilt-correction branch. Github won't let me re-open this PR though since I force pushed (I didn't know it did that)

screen shot 2018-10-16 at 8 05 33 pm

@johnboiles johnboiles mentioned this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants