Skip to content

Commit

Permalink
fix: QA Report #52 (CodeArena)
Browse files Browse the repository at this point in the history
maximebrugel committed Feb 16, 2022
1 parent 71ea2a9 commit 084f557
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion contracts/libraries/ExchangeHelpers.sol
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ library ExchangeHelpers {
/// @param _sellToken Token to exchange
/// @param _swapTarget The address of the contract that swaps tokens
/// @param _swapCallData Call data provided by 0x to fill the quote
/// @return True if the call succeeded, false if not
/// @return True if the call succeeded, false if not
function fillQuote(
IERC20 _sellToken,
address _swapTarget,
1 change: 0 additions & 1 deletion contracts/operators/Flat/FlatOperator.sol
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// SPDX-License-Identifier: GPL-3.0-or-later
pragma solidity 0.8.11;

import "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import "./IFlatOperator.sol";

/// @title The flat operator doesn't execute any logic to an input.
9 changes: 2 additions & 7 deletions contracts/operators/ZeroEx/ZeroExStorage.sol
Original file line number Diff line number Diff line change
@@ -5,15 +5,10 @@ import "@openzeppelin/contracts/access/Ownable.sol";

/// @title ZeroExOperator storage contract
contract ZeroExStorage is Ownable {
address private _swapTarget;

/// @notice Returns the address of 0x swaptarget
function swapTarget() external view returns (address) {
return _swapTarget;
}
address public swapTarget;

/// @notice Update the address of 0x swaptarget
function updatesSwapTarget(address swapTargetValue) external onlyOwner {
_swapTarget = swapTargetValue;
swapTarget = swapTargetValue;
}
}

0 comments on commit 084f557

Please sign in to comment.