[CodeArena] - Med/High Risk fixes #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-supizet
approved these changes
Feb 17, 2022
| @@ -486,6 +488,7 @@ contract NestedFactory is INestedFactory, ReentrancyGuard, OwnableProxyDelegatio | |||
| bool _fromReserve | |||
| ) private returns (IERC20, uint256) { | |||
| if (address(_inputToken) == ETH) { | |||
| require(!_fromReserve, "NF: NO_ETH_FROM_RESERVE"); | |||
There was a problem hiding this comment.
❔ I'm not sure I understand why is this one necessary.
There was a problem hiding this comment.
safe guard to not use ETH when it's from the reserve (this is possible) and the user can take the ETH from the contract
adrien-supizet
added
Can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for all "Med/High Risk issues"
Confirmed on our side for the moment (also "disagree with severity")
areOperatorsImportedcode-423n4/2022-02-nested-findings#17 (720b450)NestedFactorydoes not track operators properly code-423n4/2022-02-nested-findings#38 (1a16a51)