[CodeArena] - [G-06/N-12] : Require messages shorten to fit in 32 bytes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximebrugel
changed the title
maximebrugel
force-pushed
the
codearena-14
branch
from
43bef9a to
d3c1459
Compare
maximebrugel
suggested changes
Dec 2, 2021
contracts/MixinOperatorResolver.sol
Outdated
| @@ -60,7 +60,7 @@ abstract contract MixinOperatorResolver { | |||
| /// @return The operator address | |||
| function requireAndGetAddress(bytes32 name) internal view returns (address) { | |||
| address _foundAddress = addressCache[name]; | |||
| require(_foundAddress != address(0), string(abi.encodePacked("Missing operator : ", name))); | |||
| require(_foundAddress != address(0), string(abi.encodePacked("MOR: Missing operator : ", name))); | |||
There was a problem hiding this comment.
Maybe MOR: MISSING_OPERATOR ?
contracts/NestedFactory.sol
Outdated
| @@ -50,15 +50,15 @@ contract NestedFactory is INestedFactory, ReentrancyGuard, Ownable, MixinOperato | |||
| /// @dev Reverts the transaction if the caller is not the token owner | |||
| /// @param _nftId The NFT Id | |||
| modifier onlyTokenOwner(uint256 _nftId) { | |||
| require(nestedAsset.ownerOf(_nftId) == _msgSender(), "NestedFactory: Not the token owner"); | |||
| require(nestedAsset.ownerOf(_nftId) == _msgSender(), "NF: CALLER_IS_NOT_THE_OWNER"); | |||
There was a problem hiding this comment.
Remove the _IS_ and _THE_=> NF: CALLER_NOT_OWNER
contracts/NestedFactory.sol
Outdated
| _; | ||
| } | ||
|
|
||
| /// @dev Reverts the transaction if the nft is locked (hold by design). | ||
| /// The block.timestamp must be greater than NFT record lock timestamp | ||
| /// @param _nftId The NFT Id | ||
| modifier isUnlocked(uint256 _nftId) { | ||
| require(block.timestamp > nestedRecords.getLockTimestamp(_nftId), "NestedFactory: The NFT is currently locked"); | ||
| require(block.timestamp > nestedRecords.getLockTimestamp(_nftId), "NF: NFT_IS_LOCKED"); |
There was a problem hiding this comment.
Remove _IS_ => NF: LOCKED_NFT
maximebrugel
added
Fix and merge
adrien-supizet
force-pushed
the
codearena-14
branch
from
d3c1459 to
1691fa7
Compare
adrien-supizet
force-pushed
the
codearena-14
branch
from
1691fa7 to
71bc16e
Compare
maximebrugel
changed the title
maximebrugel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that there is no advantage to using less than 32 bytes for a require reason, but using more will cost an extra 32 at once.
I've looked at 3 options:
CustomError-> I've chosen option 1. By using initials instead of contract names, and rewriting some messages, the data now fit in 32 bytes.
Issues =>