Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peckshield PVE004 #5

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Peckshield PVE004 #5

merged 1 commit into from
Oct 15, 2021

Conversation

maximebrugel
Copy link
Contributor

telegram-cloud-photo-size-5-6282781317569555813-y

In this PVE, we can't fully fix the issue... Because most of this issue is "by design" and accepted.

The only parts we are fixing in this PR are :

  • Prevent the user from replicating a non-existent portfolio (id)
  • Prevent the user from replicating the portfolio created in the same transaction.

@maximebrugel maximebrugel added the To review Let people know this PR is ready for a review label Oct 13, 2021
@adrien-supizet adrien-supizet added Can merge Good to go and removed To review Let people know this PR is ready for a review labels Oct 15, 2021
@maximebrugel maximebrugel merged commit daf68f2 into audit-fixes Oct 15, 2021
@maximebrugel maximebrugel deleted the PVE-004 branch October 15, 2021 12:50
@maximebrugel maximebrugel removed the Can merge Good to go label Oct 18, 2021
@maximebrugel maximebrugel mentioned this pull request Oct 26, 2021
Merged
maximebrugel added a commit that referenced this pull request Feb 18, 2022
@maximebrugel
fix: gas optimizations #5 (CodeArena)
2a82425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-supizet adrien-supizet adrien-supizet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximebrugel @adrien-supizet