[CodeArena] - [G-04] : For uint replace > 0 with != 0
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
95
to
96
| while (operators[i] != operator) { | ||
| i++; | ||
| } |
There was a problem hiding this comment.
What happens when i is greater than operators.length? Does the loop continue until the tx run out of gas?
I think a more elegant logic would be a for loop that counts down from operators.length to 0. wdyt?
Moreover, when we remove an operator, I believe it is more likely to be the last one added
There was a problem hiding this comment.
This is out of scope of this PR, but still.
There was a problem hiding this comment.
This is a CodeArena issue, will be fixed :)
maximebrugel
added
Can merge
maximebrugel
force-pushed
the
codearena-8
branch
from
006c76f to
03fc18a
Compare
maximebrugel
added a commit
that referenced
this pull request
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue => code-423n4/2021-11-nested-findings#8