Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The golang.org/x/net package has issues depending on context #373

Closed
mattfarina opened this issue Apr 5, 2016 · 5 comments
Closed

The golang.org/x/net package has issues depending on context #373

mattfarina opened this issue Apr 5, 2016 · 5 comments
Labels
bug

Comments

@mattfarina
Copy link
Member

Go 1.7 will have context in the standard library. The golang.org/x/net package has a build tag for go 1.7 and that file depends on the standard library version of context.

Glide looking at all the packages across all the build flags has a problem with this.

See golang/net@afc22ee#diff-22b1e0bcbf56beea47fa8ad88e890286R5
@mattfarina mattfarina added the bug label Apr 5, 2016
@sdboyer
Copy link
Member

sdboyer commented Apr 5, 2016

😭

@rschmukler
Copy link

Just ran into this as well...

@russmatney russmatney mentioned this issue Apr 5, 2016
Open
@rschmukler rschmukler mentioned this issue Apr 5, 2016
Closed
@bfitzsimmons
Copy link

Ran into this today.

@mattfarina
Copy link
Member Author

I hope to have this fixed (with a release) in the next day.

@mattfarina
Copy link
Member Author

There's a fix posted to #376.

mattfarina added a commit that referenced this issue Apr 5, 2016
@mattfarina
Merge pull request #376 from Masterminds/fix-context
51f3c74 
Fixes #373: Go 1.7 context package import issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sdboyer @mattfarina @bfitzsimmons @rschmukler