-
Notifications
You must be signed in to change notification settings - Fork 451
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Documenting and testing for deep copying with merging of dicts
Two things happen here: 1. A test is put into place for this situation to show the merge with and without a deep copy 2. Documentation is updated to show how to use deepCopy with merging
- Loading branch information
1 parent
1394834
commit e256eac
Showing
2 changed files
with
47 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
package sprig | ||
|
||
import ( | ||
"testing" | ||
) | ||
|
||
func TestIssue188(t *testing.T) { | ||
tests := map[string]string{ | ||
|
||
// This first test shows two merges and the merge is NOT A DEEP COPY MERGE. | ||
// The first merge puts $one on to $target. When the second merge of $two | ||
// on to $target the nested dict brought over from $one is changed on | ||
// $one as well as $target. | ||
`{{- $target := dict -}} | ||
{{- $one := dict "foo" (dict "bar" "baz") "qux" true -}} | ||
{{- $two := dict "foo" (dict "bar" "baz2") "qux" false -}} | ||
{{- mergeOverwrite $target $one | toString | trunc 0 }}{{ $__ := mergeOverwrite $target $two }}{{ $one }}`: "map[foo:map[bar:baz2] qux:true]", | ||
|
||
// This test uses deepCopy on $one to create a deep copy and then merge | ||
// that. In this case the merge of $two on to $target does not affect | ||
// $one because a deep copy was used for that merge. | ||
`{{- $target := dict -}} | ||
{{- $one := dict "foo" (dict "bar" "baz") "qux" true -}} | ||
{{- $two := dict "foo" (dict "bar" "baz2") "qux" false -}} | ||
{{- deepCopy $one | mergeOverwrite $target | toString | trunc 0 }}{{ $__ := mergeOverwrite $target $two }}{{ $one }}`: "map[foo:map[bar:baz] qux:true]", | ||
} | ||
|
||
for tpl, expect := range tests { | ||
if err := runt(tpl, expect); err != nil { | ||
t.Error(err) | ||
} | ||
} | ||
} |