Add fromJson and mustFromJson funcs #223
Conversation
| // mustFromJson decodes JSON into a structured value, returning errors. | ||
| func mustFromJson(v string) (interface{}, error) { | ||
| var output interface{} | ||
| err := json.Unmarshal([]byte(v), &output) |
There was a problem hiding this comment.
This will silently fail if v cannot be converted to a []byte. The type conversion should be checked.
There was a problem hiding this comment.
That's a compile time check. I believe all strings can be converted to byte slices. (This is not a type assertion.)
There was a problem hiding this comment.
Sorry, you're right. However, I would extend the function to also accept []byte as an input.
There was a problem hiding this comment.
Data flowing between template functions can be of any type. It's entirely possible that someone will want to use this function with a []byte, for example:
{{ (readFile "foo.json" | fromJson).bar }}
where readFile returns a []byte. Why not allow this?
There was a problem hiding this comment.
We can. I was just wondering what the use case was.
|
Hi! I am really keen to see this merged and become usable. Is there anything I can do to help? Is the only thing outstanding here to change input type from |
|
+1, this feature could be very helpful |
|
This feature would be incredibly useful. How can we get this done? |
|
@mholt In reference to your editors suggestions... that would change the public API of this library. That would mean a major version increment so they will have to wait until then. When this version of the library was being written Go modules were still in transition. Breaking APIs was a real issue at that time for some so we avoided it back then. This is just the context of why the capitalization is what it is. |
|
That's understandable; thanks for the merge! |
In the same vein of Masterminds#223, add YAML conversion functions. Fixes Masterminds#358.
* feat: add yaml to/from functions In the same vein of Masterminds#223, add YAML conversion functions. Fixes Masterminds#358. * chore: bump yaml version to v3 --------- Co-authored-by: Blake Pettersson <[email protected]>
Resolves #35; I also found us needing this in Caddy. See caddyserver/caddy#2736 (comment).
Incidentally, my editor made a number of good points that I agree with:
I don't suppose there's any chance of fixing these... (v4?)
Also, JSON functions should probably documented along with the encoding functions, maybe?