-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additions to providers.json #143
Conversation
While I agree that reserving |
I did not find anywhere in the spec where it said "type" must be "provider" here. But, if we change it to something like "reserved_prefix", the file probably shouldn't be 'providers.json'. Standardizing a |
Requesting reviews from a list of people to either get this approved or at least understand if this is controversial, and I should move out the (hopefully non-controversial) 'httk' prefix in a separate PR. (I suppose none of these changes are release-blocking for v0.10, but with this system of "ask for a prefix via a PR" it is nice if we don't drag too long on such requests.) |
I second @merkys that seeing cif as provider sounds strange, but probably the best solution for the current situation these are actually the providers of the terms (metadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR to get httk
and optimade
prefixes into 0.10.0. I have some reservations regarding the status of cif
as a provider, but we can adjust that later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with adding HTTK. Actually, I'll probably add another PR to add the aiida
prefix.
It's also ok that it's wise to reserve optimade
, even if don't have an official optimade
provider yet, it's better to reserve it to avoid confusion.
Instead I would remove cif
- I don't see the usecase, this should be in my view the list of providers, and the id
s are to be used in the form _ID_xxx
for keywords. So I'm not sure this extension is correct. I would remove this for this PR and we rediscuss.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @giovannipizzi , cif
is a format an thus orthogonal to providers. So a provider, say _cod_
can offer a response format cif
.
optimade
is a useful addition.
Ok, I removed 'cif' as it clearly needs more discussion. Please re-approve the new version.
The cif dictionaries provide a large number of already standardized properties. At least between e.g., httk and (I assume) cod, we will both be embedding data based directly on these. It would be nice with one common standardized prefix for these.
In my view, there are three different entities that have use for reserved prefixes:
But I note that in the spec right now, "provider" is defined broadly enough that it applies to 1 and 2, so with this we are in an OK shape as it is (without cif). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, I agree that at this point only 1 and 2 are covered.
For a common prefix for properties, this is something that needs to be specified in the specs (also because I think you are imagining to have properties like cif_xxx
rather than _cif_xxx
).
I had very much fully intended to use I suppose we could standardize on @sauliusg I'm not talking about cif as an output format (which is also a good idea), I am talking about serving e.g., |
Similar to Materials-Consortia#143, where `httk` was added for the software in parallel to `omdb` for the database, here we add `aiida` as the prefix for the AiiDA software (www.aiida.net) in parallel to the `mcloud` prefix for the Materials Cloud (www.materialscloud.org) online database. Moreover, I'm clarifying and improving the description of the Materials Cloud entry.
I'd like to add provider 'httk' in providers.json, even though it is more of a framework than a database ("my" database is 'omdb'). I need this for providing 'httk'-specific features under an
_httk_
prefix namespace that will be common to everyone who uses httk, which is separate from the namespace_omdb_
that I'll use completely local to the omdb database.I see a similar need for our optimade implementations and libraries. So, it probably does not hurt to reserve the
_optimade_
prefix for us. So that is also in this PR.Furthermore, and this I suppose can be more controversial, we might want to also reserve
_cif_
as a common standard for embedding cif filelds inside OPTiMaDe. (But if there is opposition to this, I'm fine with take it out or extract it into a separate PR.)