-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ranged properties #452
Closed
JPBergsma
wants to merge
35
commits into
Materials-Consortia:develop
from
JPBergsma:JPBergsma/Add_ranged_properties
Closed
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
c18cf0c
Intermediate state adding ranged properties.
JPBergsma 7dc50f2
Merge branch 'develop' into JPBergsma/Add_ranged_properties
JPBergsma 6afcf9c
first draft for ranged properties.
JPBergsma 1a55c2a
Merge branch 'develop' into JPBergsma/Add_ranged_properties
JPBergsma b597a67
Removed average, set, min and max fields for now as these become quit…
JPBergsma 37db878
Small corrections.
JPBergsma a832751
Added how to treat missing values for requested range.
JPBergsma 16aba07
changed description field
JPBergsma b1d69a8
Apply suggestions from code review
JPBergsma edbfc25
Merge branch 'Materials-Consortia:develop' into JPBergsma/Add_ranged_…
JPBergsma 14de45d
Apply suggestions from code review Vaitkus
JPBergsma 906db81
intermediate state from implementing code review.
JPBergsma 1feb4a9
Merge branch 'JPBergsma/Add_ranged_properties' of https://github.com/…
JPBergsma a96dffe
Processed comments rartino.
JPBergsma 15f599c
Small corrections.
JPBergsma 73905dc
Added returned range property.
JPBergsma c6834f3
Added extra explanation values field.
JPBergsma b0cc94c
Apply suggestions from code review
JPBergsma 0cee1e6
Merge branch 'develop' into JPBergsma/Add_ranged_properties
JPBergsma d7c8a9c
Processed comments rickard and a few more small improvements.
JPBergsma d1e8d74
Further changes after proof reading.
JPBergsma 139c70e
further refinements.
JPBergsma 916d6f2
Changed 'n_' to 'n' for ranged metadata properties tio be consistent …
JPBergsma ee3651e
Changed wording of range_id field after suggestion Rickard.
JPBergsma 1f794b6
placed subsequent sentences on seperate lines.
JPBergsma 169a1f4
Processed points discussed with Rickard.
JPBergsma f513596
Added per entry next field + small corrections.
JPBergsma 65b8ad1
Apply suggestions from code review
JPBergsma 94db38c
Adjusted the description next fields for ranged properties.
JPBergsma 033ea11
Corrected range name for _exmpl_ranged_thermostat.
JPBergsma 3762d30
Added that querying on properties in the range dictionary is optional.
JPBergsma 8332567
Specifically mention that support for queries directly on the values …
JPBergsma a87b301
Updated example to latest version metadata proposal and added more ex…
JPBergsma 7e9b4f4
Improved explanation returned_range field.
JPBergsma 4b298c5
Small corrections.
JPBergsma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "contains_null" not be a more generic metadata property that could also apply to other non-ranged fields ?
Ps. This would also allow querying on whether a property contains_null, now that I have placed in the description that support for queries on the fields under "range" is optional.