-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECMA definition of symmetry operation regexp and associated tests #488
Add ECMA definition of symmetry operation regexp and associated tests #488
Conversation
Have tagged reviewers but no pressure to look at this before 2024! |
- Uses the proposed ECMA regexp at Materials-Consortia#488
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in principle. As details go, I suggest adding a test that compares the original PCRE REs and the ECMA REs, by generating automatically the ECMA RE from the PCRE by interpolating variables (should be easy to do in Perl) and comparing them with the ECMA RE provided in the specification. In this way we would know that if tests pass, both sets of REs define the same thing.
I've added the 'requires-discussion' label in preparation of the web meet, as it seems we may want to generally find a consensus around the 'pattern' field. (I suppose I could have added the label on #490 instead, but technically it is the possible reference to that appendix from here that is the topic to discuss). |
Co-authored-by: Antanas Vaitkus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool test 'symops_pcre_to_ecma_001.sh', I think it is sufficient to safeguard that ECMA and PCER symop definitions do not diverge. Well done!
Co-authored-by: Andrius Merkys <[email protected]>
Closes #487.
This PR adds an explicit and simplified symmetry operation regexp that can be used with JSON Schema.
It is validated against the same test cases as the PCRE version with an exact match in the results.