Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator verbosity levels need more detailed description #396

Closed
merkys opened this issue Jul 10, 2020 · 0 comments · Fixed by #395
Closed

Validator verbosity levels need more detailed description #396

merkys opened this issue Jul 10, 2020 · 0 comments · Fixed by #395
Labels
priority/low Issue or PR with a consensus of low priority suggestions validator Related to the OPTIMADE validator

Comments

@merkys
Copy link
Member

merkys commented Jul 10, 2020

optimade_validator has command line option --verbosity which controls the level of program's verbosity. It would be very nice to have the verbosity levels enumerated in the output of --help option.
@merkys merkys added priority/low Issue or PR with a consensus of low priority validator Related to the OPTIMADE validator suggestions labels Jul 10, 2020
ml-evs added a commit that referenced this issue Jul 10, 2020
@ml-evs
Improve --verbosity help string for validator (closes #396)
234fde7
ml-evs added a commit that referenced this issue Jul 10, 2020
@ml-evs
Improve --verbosity help string for validator (closes #396)
87d3c63
ml-evs added a commit that referenced this issue Jul 10, 2020
@ml-evs
Improve --verbosity help string for validator (closes #396)
442a407
@ml-evs ml-evs mentioned this issue Jul 10, 2020
Merged
ml-evs added a commit that referenced this issue Jul 16, 2020
@ml-evs
Improve --verbosity help string for validator (closes #396)
a1211c0
ml-evs added a commit that referenced this issue Jul 17, 2020
@ml-evs @CasperWA @merkys
Fix some validator-specific crashes (#395)
93e50b1 
* Give validator patched `included` a default value to make it really optional (closes #393)

* Validate relationships data as a list before testing type (closes #397)

* Improve --verbosity help string for validator (closes #396)

* Add concept of InternalErrors to validator

These errors should be handled differently to ValidationError and
ResponseError as they indicate a problem with the validator itself.

* Added validator flags --fail_fast and --skip_optional_tests

* Improvements to pagination validation

- Allow links objects to be passed in pagination
- Enforced maximum recursion depth (5) for pagination tests

* Reduce set of example queries from the specification, pending future improvements (#357)

* Improve error message for single entry endpoint if deserialization fails

* Implemented suggestions from code review

Co-authored-by: Casper Welzel Andersen <[email protected]>

* Renamed entrypoint optimade_validator->optimade-validator

* Flip arg options the "standard" way around

Use -t for --as-type (instead of -a).

Co-authored-by: Casper Welzel Andersen <[email protected]>
Co-authored-by: Andrius Merkys <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/low Issue or PR with a consensus of low priority suggestions validator Related to the OPTIMADE validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix some validator-specific crashes Materials-Consortia/optimade-python-tools
1 participant
@merkys