-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate mandatory query field structure_features
#678
Comments
So the reason we're not validating this at the moment is that the validator can never find any values to query for with structure features, as the list is empty for almost everyone. This might be an easy fix to replace an |
Why not just test for a value we know could be present (from the models)? The point is more that the implementation should at least return an empty array if there are no structures with the chosen value. I.e., they shouldn't fail with errors or similar. |
Yup, that's what I'm trying to do now, just needs some extras added to the config. |
Co-authored-by: Casper Welzel Andersen <[email protected]>
Co-authored-by: Casper Welzel Andersen <[email protected]>
I would argue they all should still fail due to them not supporting the mandatory query on
structure_features
.OMDB: http://optimade.openmaterialsdb.se/v1.0.0/structures?filter=NOT%20structure_features%20HAS%20ALL%20%22assemblies%22Edit: fixed as reported in [OPTIMADE] Support for queries onstructure_features
httk/httk#32.Originally posted by @CasperWA in #676 (comment)
The validator should fail an implementation if querying
structure_features
fails, since it is mandatory to support queries for this field (in the/structures
endpoints).The text was updated successfully, but these errors were encountered: