-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specification of provider field descriptions/units etc. in config file #1096
Conversation
20388bb
to
936db62
Compare
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
+ Coverage 92.53% 92.63% +0.09%
==========================================
Files 67 67
Lines 3806 3813 +7
==========================================
+ Hits 3522 3532 +10
+ Misses 284 281 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This seems a useful addition as I am still struggling with getting the provider specific fields of the Trajectories endpoint. |
Cheers, |
16d088e
to
936db62
Compare
ef4c899
to
242b22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still wondered whether it would be worthwhile to make a function/method for returning the "name" field.
Now you have to do extra type checks at three places in the code.
Other than that, it looks good to me.
Thanks for the review @JPBergsma! Point taken, I tried to avoid over-engineering this but the balance might not be quite right --- I think it's fine for now as there shouldn't be any other places where this check is necessary, if that changes then we can refactor. |
Closes #1095.
This PR also enables some old tests for provider fields that we had disabled.