Make structure adapters infer species
from species_at_sites
when missing
#1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep running into this issue where implementations do not return
species
by default, because their species dictionaries are extremely simple (i.e., single chemical symbol per species, no disorder, and the name follows the element symbol).This PR allows the ASE, AiiDA and pymatgen structure adapters to infer this simple structure from just
species_at_sites
whenspecies
is missing/None.