-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heroku deployment scripts #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea and will surely be useful, cheers @ltalirz!
I see it introduces the requirements file again, is this just for heroku to use? Could it be put in e.g. .heroku
or somewhere off the top-level to avoid confusion, or are we moving back to using it for all oru deps?
Yes
Not sure, I could try but it needs to be detected by heroku. For me that would seem fine, since people installing the app will typically want to run the server. |
I don't agree. As an example, we (Materials Cloud) do not want to run the server. Although, with the addition of the index meta-database server, we do want to run that. Maybe with the addition of the index meta-database, which can be properly configured using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great little tool, thanks @ltalirz!
However, along with @ml-evs I am a bit concerned about the re-addition of the requirements.txt
- we essentially already have it under .github/
for GH Actions.
Furthermore, along the lines of @ml-evs's comment, with the re-structuring of the package, it would be nice to put specific heroku files under a dedicated directory if possible.
README.md
Outdated
@@ -1,4 +1,5 @@ | |||
[![Build Status](https://travis-ci.org/Materials-Consortia/optimade-python-tools.svg?branch=master)](https://travis-ci.org/Materials-Consortia/optimade-python-tools) | |||
[![Heroku](https://heroku-badge.herokuapp.com/?app=optimade&root=optimade/info)](https://optimade.herokuapp.com/optimade) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this gets merged before #68, could you please make sure this gets added to that PR?
Pipfile breaks heroku build: An error occurred while installing 3-5! Will try again.
found no way to specify the 'server' extra on heroku.
this might be a way to install the "server" extra
ok, I've worked around the |
Thanks for the changes @ltalirz! Happy to accept this once we we've merged the readme PR. Quick question in the meantime: how is the heroku auth set up? Is it your personal account or can anyone modify the config? I see they have a github action actions/heroku which might circumvent this (if it's not too much extra effort)? (I've never used heroku so apologies if these questions are irrelevant) |
Heroku has the concept of "apps" and access can be configured for each app individually.
I don't think this would significantly change things, since in the end you still need to set up the app. |
Okay, cheers! If you can fix the README conflicts then I'll accept. |
Fixed the conflict. I could leave it like this or perhaps remove the "commit activity" one to go back to one line. |
Up to you, I'll accept either way. |
I've now pointed the app to the official optimade-python-tools repo. |
This PR adds a deployment of the optimade server to heroku - integrated with CI, this allows us to always have a working optimade server of the current development branch (or master, whatever we like) to play around with.
This could be used to e.g. have an "interactive" documentation with this server + swagger (see also Materials-Consortia/materials-consortia.github.io#5 ).
optimade.herokuapp.com is currently linked to my fork of optimade-python-tools but I'll relink it to the main repository once this is reviewed & merged.
Test: https://optimade.herokuapp.com/optimade/structures