-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling for client when updating provider list #1222
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1222 +/- ##
==========================================
- Coverage 91.29% 91.23% -0.06%
==========================================
Files 72 72
Lines 4294 4299 +5
==========================================
+ Hits 3920 3922 +2
- Misses 374 377 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
d29cabd
to
7d35132
Compare
Would you mind taking a look at this @JPBergsma? |
7d35132
to
90692f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late response.
I have just been on holiday and there is a whole flood of messages from the last OPTIMADE meeting that I still have to get through.
The changes look good to me.
No problem @JPBergsma, hope you had a good holiday! I am very much still catching up too 😅 No need to rush through the other PRs. |
90692f2
to
cddc6c5
Compare
45b716f
to
04cbe8f
Compare
Timeouts/errors were previously not being caught when querying index meta-databases.