-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added homepage attribute to LinksResource #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there's some trouble concerning getting the tests to run.
And I could swear i already did this, but maybe that was for something else? Oh well :)
Looking good 👍
Co-Authored-By: Casper Welzel Andersen <[email protected]>
I'll look at this next week hopefully. EDIT: Scratch that. Figured out the issue (see below). |
This is blocked until Materials-Consortia/providers#7 has been merged, adding |
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage ? 83.05%
=========================================
Files ? 39
Lines ? 1841
Branches ? 0
=========================================
Hits ? 1529
Misses ? 312
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine now - let's merge.
Thanks @ml-evs !
See #115