Add meta.description to BaseRelationshipResource #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sub-classed BaseResource to introduce special OPTiMaDe requirement of having an OPTIONAL `meta` field in the relationship resource, which MUST have the field `description`, it it's present. Also, introduced some pylint disables for the models to avoid pylint complaining about long lines and wrong use of `self` for validators (which are class methods, hence they should NOT have the `self` argument).
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 83.05% 83.11% +0.06%
==========================================
Files 39 39
Lines 1841 1848 +7
==========================================
+ Hits 1529 1536 +7
Misses 312 312
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-classed BaseResource to introduce special OPTiMaDe requirement of
having an OPTIONAL
metafield in the relationship resource, whichMUST have the field
description, it it's present.Also, introduced some pylint disables for the models to avoid pylint
complaining about long lines and wrong use of
selffor validators(which are class methods, hence they should NOT have the
selfargument).