Non Local Mongo #150
Merged
Non Local Mongo #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
previously approved these changes
Jan 30, 2020
| else: | ||
| from mongomock import MongoClient | ||
|
|
||
| client = MongoClient() | ||
| client = MongoClient() |
There was a problem hiding this comment.
Is this not a possibility in mongomock? Or maybe it just doesn't make sense?
There was a problem hiding this comment.
It actually works fine as far as code goes, but it's probably not guaranteed behavior, so it doesn't hurt to separate the two unless we're getting issues elsewhere like linting.
There was a problem hiding this comment.
It was merely for the elegance of the code as it was - only having one line for the instantiation of the client - but never mind.
|
Ah, I see there's a test failing for blackening. Could you possibly install pre-commit (run |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch enables using a non-local mongo server by supplying a URI string in the config