Replace httpx usage in synchronous OptimadeClient with requests
#1536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/tweak_client
branch
from
0a5e65f to
4078417
Compare
ml-evs
changed the title
ml-evs
force-pushed
the
ml-evs/tweak_client
branch
2 times, most recently
from
0323e44 to
619e2dc
Compare
- Add very general exception handling for client - Also explicitly force no async when an event loop is running
ml-evs
force-pushed
the
ml-evs/tweak_client
branch
from
619e2dc to
afa2ce9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1536 +/- ##
==========================================
- Coverage 91.08% 91.07% -0.02%
==========================================
Files 74 74
Lines 4533 4538 +5
==========================================
+ Hits 4129 4133 +4
- Misses 404 405 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ml-evs
changed the title
OptimadeClient with requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of a last minute patch before the tutorials... it seems like we don't handle the case of getting IP banned from an API (which may well happen!) when the client is in non-async mode --- fix this for now by adding a very general exception handler to the request.
ALSO: client hangs even in sync mode within Jupyter notebooks.
The cause of this is that at some point httpx removed support for non-async code altogether, even in the sync client. The fix is to just defer to
requestsat this point. That is what is implemented in this PR, which now allows the client to be properly used within Jupyter/Colab.Unfortunately I am going to have to merge and release without a review, given that the tutorial is in about 12 hours... I'm pretty confident that this is working well though and I was able to update the testing harness with only a couple of lines.
Closes #1527 and closes #1195 (for now -- async still doesn't work inside a jupyter notebook but at least it now runs).