-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate list LENGTH
queries with validator
#1637
Conversation
9ee9c08
to
581e8e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see anything wrong with this code, but we have to at least prevent the triggering of the error we are currently getting for LENGTH queries on the structure features. Although, I think it would be better if we could support the LENGTH operator in a more universal manner. For MongoDB this should be possible with the size operator:
db.structures.find( {"property_name": { $size: 3 } } )
We already do this generically for MongoDB but Elastic is causing the problem, simply because |
Codecov Report
@@ Coverage Diff @@
## master #1637 +/- ##
=======================================
Coverage 91.04% 91.04%
=======================================
Files 74 74
Lines 4578 4580 +2
=======================================
+ Hits 4168 4170 +2
Misses 410 410
Flags with carried forward coverage won't be shown. Click here to find out more.
|
11429ec
to
c86b126
Compare
If you're good with this now @JPBergsma I think I will merge and release to get this up on the dashboard! |
As above.
Also tweaks the test for bad versions by hitting
/v1234/info
instead of a landing page.