Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github actions for non-release tags #235

Merged
merged 2 commits into from
Mar 16, 2020
Merged

Fix github actions for non-release tags #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07cb390
fix running on non-rls tags
Mar 16, 2020
9c3cef0
Merge branch 'master' into fix-rls-on-tag
Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/publish-on-pypi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ on:
tags:
# After vMajor.Minor.Patch _anything_ is allowed (without "/") !
- v[0-9]+.[0-9]+.[0-9]+*
branches:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that this will work, but the release should do it, I belieeve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combination of both do it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we test it with some a pre-release tag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(after merging)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just do a patch release v0.7.1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combination of both do it.

I'm not sure the github actions logic work this way, is my only concern. It's not AND statements, but rather OR as I understand it, but I may definitely be wrong, since it also seems to update a bit at the moment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the actions run (here) it seems clear it's an OR logic, i.e., the workflow ran on a push to the branch master. But didn't release on PyPI only due to the check in the code that the version in __init__.py doesn't match.

# Only for tags on master branch
- master
release:
# Only when tag is created via github release
types:
- created

jobs:
publish:
Expand Down