Add dependabot and last commit date badges #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use svg images for the heroku badge.
CasperWA
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 43 43
Lines 1943 1943
=======================================
Hits 1697 1697
Misses 246 246
Continue to review full report at Codecov.
|
shyamd
approved these changes
Mar 19, 2020
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use svg images for the heroku badge.
See the resulting README here.
I have spent some time looking into other heroku badge services, in order to see if we can get a logo on there as well. Unfortunately, there doesn't seem to be a straightforward way of doing this. The service we are currently using are showing us images from its repo, no redirecting through shields.io or something similar. Another service here do use badges generated from shields.io, including logo, but we would need to deploy it on our heroku account. In the end, it seems like too much work for a logo - I'd just stay with what we have now, since it works fine.
Just a little comment for the future :)