-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 252 missing landing page #253
Fix 252 missing landing page #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 89.32% 89.32%
=======================================
Files 54 54
Lines 2220 2220
=======================================
Hits 1983 1983
Misses 237 237
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shyamd, well spotted. We must have lost this in a restructure or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw your issue and immediately made the exact same fix - just to find you've already fixed it yourself 😅
Looks great, I think there is just a slash missing in the MANIFEST, but otherwise, all good - thanks @shyamd !
Co-Authored-By: Casper Welzel Andersen <[email protected]>
All good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good 👍
Please squash+merge :)
Thanks @shyamd !
Ensures the static contents are in the
sdist
Fixes #252