Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 252 missing landing page #253

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Fix 252 missing landing page #253

merged 3 commits into from
Apr 24, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Apr 24, 2020

Ensures the static contents are in the sdist

Fixes #252

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          54       54           
  Lines        2220     2220           
=======================================
  Hits         1983     1983           
  Misses        237      237           
Flag Coverage Δ
#unittests 89.32% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd20c4...14673f9. Read the comment docs.

ml-evs
ml-evs previously approved these changes Apr 24, 2020
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shyamd, well spotted. We must have lost this in a restructure or something.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your issue and immediately made the exact same fix - just to find you've already fixed it yourself 😅

Looks great, I think there is just a slash missing in the MANIFEST, but otherwise, all good - thanks @shyamd !

MANIFEST.in Outdated Show resolved Hide resolved
Co-Authored-By: Casper Welzel Andersen <[email protected]>
@shyamd
Copy link
Contributor Author

shyamd commented Apr 24, 2020

All good?

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍
Please squash+merge :)

Thanks @shyamd !

@shyamd shyamd merged commit 20323c6 into Materials-Consortia:master Apr 24, 2020
@shyamd shyamd deleted the fix-252-missing-landing-page branch April 24, 2020 15:13
@ml-evs ml-evs mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install missing some files
3 participants