Use heroku-shields instead of heroku-badge #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now add a logo to the badge and still have testing of whether heroku is up or not.
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
=======================================
Coverage 90.03% 90.03%
=======================================
Files 54 54
Lines 2269 2269
=======================================
Hits 2043 2043
Misses 226 226
Continue to review full report at Codecov.
|
ml-evs
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now add a logo to the badge and still have testing of whether heroku is up or not.
Might as well update this as well 😄
The heroku instance we usually use to get the badge is down and is quite rigid. This new one is up and let's us use shield.io better. The new one is using this.
It looks thus:
