-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Represent the datetime objects as UTC in RFC3339 format #333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 90.56% 90.57% +0.01%
==========================================
Files 55 55
Lines 2268 2271 +3
==========================================
+ Hits 2054 2057 +3
Misses 214 214
Continue to review full report at Codecov.
|
This reverts commit be037a8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fekad !
I've put it some comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch @fekad for the detailed analysis on top of this 👍
Fixing #288
According to the conversation in the issue, the response always returns with the UTC time in RFC3339 format even if it is not aligned to the actual timezone where the API is running.