Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use optimade-validator-action v2 #413

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Use optimade-validator-action v2 #413

merged 2 commits into from
Jul 17, 2020

Conversation

CasperWA
Copy link
Member

Update to using the OPTIMADE Validator Action v2.

This is currently blocked, since v2 has not yet been released (but soon will be).

@CasperWA CasperWA marked this pull request as ready for review July 17, 2020 16:28
@CasperWA CasperWA requested review from ml-evs and shyamd July 17, 2020 16:28
@CasperWA CasperWA changed the title [BLOCKED] Use optimade-validator-action v2 Use optimade-validator-action v2 Jul 17, 2020
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files          55       55           
  Lines        2522     2522           
=======================================
  Hits         2295     2295           
  Misses        227      227           
Flag Coverage Δ
#unittests 90.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6551e2...d434852. Read the comment docs.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't have done it better myself!

@CasperWA CasperWA merged commit 35f358a into master Jul 17, 2020
@CasperWA CasperWA deleted the update_validator_action branch July 17, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants